fix(engine-bridge): enforce LRU bound after revalidation - #225
Merged
Conversation
N-thnI
approved these changes
Aug 24, 2026
Contributor
|
Merged — thanks for the contribution! If you've got a moment, a rating on GrantFox helps the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent
ChainStateCache.revalidate()from resurrecting an evicted entry without reapplying the configuredmaxEntriesLRU bound.The successful background-revalidation path now enforces the same cache-size limit as the cache-miss path. A deterministic deferred-promise regression test covers eviction while revalidation is pending and verifies the resulting LRU order.
Related Issue
Closes #201
Changes Made
evictIfNeeded()immediately after a successful background revalidation write.maxEntries;isRevalidatingreset behavior.Testing Performed
cargo test/npm test)ChainStateCachesuite: 11 tests passed.engine-bridgesuite: 87 tests passed across 13 suites.engine-bridgeand dashboard suites passed.engine-bridge:npm run builddashboard:npm run buildengine-bridge:npm run lint— 0 errors.dashboard:npm run lint— passed.cargo build --target wasm32-unknown-unknown --releasegit diff --checkChecklist
fix/201-revalidation-lru-bound)Closes #201reference is present above (linking this PR to the issue)